Fix gradient-checkpointing option is ignored in SDXL+LoRA training. (#6388)#6402
Merged
sayakpaul merged 5 commits intohuggingface:mainfrom Jan 1, 2024
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
Author
|
@sayakpaul Here is a PR for #6388. |
sayakpaul
reviewed
Dec 31, 2023
Comment on lines
+709
to
+710
| if args.gradient_checkpointing: | ||
| unet.enable_gradient_checkpointing() |
Member
There was a problem hiding this comment.
The text encoder can be trainable in this script too:
This is how it's done:
Contributor
Author
|
@sayakpaul Thanks for your review. Fixed that in 8d7feb6. |
sayakpaul
approved these changes
Dec 31, 2023
Member
|
Thanks for your contributions. |
antoine-scenario
pushed a commit
to antoine-scenario/diffusers
that referenced
this pull request
Jan 2, 2024
…uggingface#6388) (huggingface#6402) * Fix gradient-checkpointing option is ignored in SDXL+LoRA training. (huggingface#6388) * Fix gradient-checkpointing option is ignored in SD+LoRA training. * Fix gradient checkpoint is not applied to text encoders. (SDXL+LoRA) --------- Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
…uggingface#6388) (huggingface#6402) * Fix gradient-checkpointing option is ignored in SDXL+LoRA training. (huggingface#6388) * Fix gradient-checkpointing option is ignored in SD+LoRA training. * Fix gradient checkpoint is not applied to text encoders. (SDXL+LoRA) --------- Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a problem in SDXL LoRA training script that ignores gradient checkpointing option.
Fixes #6388
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.